Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align with RFC8288, update .txt & .html to be actual rendered versions of .xml #1329

Merged
merged 7 commits into from Oct 18, 2019
Merged

Align with RFC8288, update .txt & .html to be actual rendered versions of .xml #1329

merged 7 commits into from Oct 18, 2019

Conversation

equalsJeffH
Copy link
Contributor

@equalsJeffH equalsJeffH commented Oct 18, 2019 •
edited by pr-preview bot

@equalsJeffH equalsJeffH added this to the IETF-106 milestone Oct 18, 2019
@equalsJeffH equalsJeffH self-assigned this Oct 18, 2019
@equalsJeffH
Copy link
Contributor Author

equalsJeffH commented Oct 18, 2019 •
edited

thanks for the comments, tho they aren't attached to lines since they were done against a pushed-branch-lacking-a-PR AFAICT, so sorta winging it here, the below fixups are in 6bb9b19 (.txt & .html renderings match .xml)...

Remove the linebreaks after <eref …> and before , as I believe the will cause extra whitespace.

I have verified that the linebreaks after <eref> do not affect .txt & .html rendering. said linebreaks make the .xml easier for me to read, so am leaving them in.

Remove the linebreak before , as it will cause an extra blank before the colon.

I think I fixed this.

Change this to "Section 7 of ".

done.

Delete the space before .

no can find. fixed?

Change "Ben's" to "Benjamin Kaduk's".
Add the missing space in "RFC 8288".

done.

selfissued
selfissued approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Shall I merge? Or I'm fine with you doing so, @equalsJeffH .

@equalsJeffH equalsJeffH merged commit a55edbf into master Oct 18, 2019
WebAuthnBot pushed a commit that referenced this pull request Oct 18, 2019
Built by Travis-CI: a55edbf Align with RFC8288, update .txt & .html t…
717fd3b 
…o be actual rendered versions of .xml (#1329)
WebAuthnBot pushed a commit that referenced this pull request Oct 18, 2019
Built by Travis-CI: a55edbf Align with RFC8288, update .txt & .html t…
2e44e66 
…o be actual rendered versions of .xml (#1329)
@emlun emlun deleted the jeffh-registries-revisePerADReview2 branch October 21, 2019 10:55
emlun pushed a commit that referenced this pull request Nov 6, 2019
@equalsJeffH @emlun
Align with RFC8288, update .txt & .html to be actual rendered version…
c918479 
…s of .xml (#1329)

* begin addressing AD comments

* update rendered .txt & .html to match .xml: these all are -03a (further commits to follow)

* editorial: fixup line-ending char, indentation, some section anchors

* Align with RFC8288, rather than draft-nottingham-rfc5988bis. -03 release candidate

* update .txt .html to be actual rendered versions of .xml

* fix error in .xml, update .html & .txt to match .xml
@emlun emlun mentioned this pull request Nov 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selfissued selfissued selfissued approved these changes

Assignees

@equalsJeffH equalsJeffH

Labels
spec:webauthn-registries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@equalsJeffH @selfissued