Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update extensions framework to include interfacing with user agent permissions framework #133

Closed
equalsJeffH opened this issue Jun 22, 2016 · 14 comments

Comments

@equalsJeffH
Copy link
Contributor

update extensions framework to include interfacing with user agent permissions framework

@equalsJeffH equalsJeffH added this to the CR milestone Aug 22, 2016
@equalsJeffH
Copy link
Contributor Author

see also #208

@selfissued
Copy link
Contributor

@equalsJeffH is there anything left to do for this issue? If so, are the concrete proposed changes? If not, we should close this one.

@nadalin
Copy link
Contributor

nadalin commented Aug 10, 2017

@equalsJeffH , @selfissued Can we close this one since Mike has redone the extension section ?

@equalsJeffH
Copy link
Contributor Author

@AngeloKai has asserted that interfacing with the permissions framework is not applicable for webauthn in this context, and AFAIK we've just accepted that, so closing this. tho, if someone disagrees please cite appropriate specs etc.

@riking
Copy link

riking commented Dec 5, 2017

I feel like this should be addressed - it seems like a mistake to allow websites to get geolocation information without the user being notified.

Here's a quick and dirty draft:

Client extension processing

Check the [[permissions state]] for geolocation. If the permission state is "denied", the client MUST remove the extension and not pass it to the authenticator. If the permission state is "prompt", the user agent MAY prompt the user and restart this processing, MAY remove the extension without prompting, or MAY treat it as a "granted" state. If the permission state is "granted", the client creates the authenticator extension input with the Boolean value true.

@equalsJeffH
Copy link
Contributor Author

reopening due to #133 (comment)

@equalsJeffH equalsJeffH reopened this Dec 19, 2017
@equalsJeffH
Copy link
Contributor Author

It seems that having the geoloc extension check the permissions framework is a resonable thing since geoloc is a defined permision in: https://w3c.github.io/permissions/#permission-registry

@gmandyam
Copy link

@equalsJeffH

Wouldn't the client (UA) check the permissions framework, rather than the extension implementation itself? Since the client can choose to drop extensions, it can use the permissions framework as part of the criteria in determining whether to drop or not.

@equalsJeffH
Copy link
Contributor Author

@gmandyam
Yeah, that might be the case, perhaps the extension only needs to say that the client platform ought to check permissions as appropriate and if available, e.g., geoloc, and reference https://w3c.github.io/permissions/ ?

@selfissued
Copy link
Contributor

I agree that the client platform should do this check - not the extension

@nadalin
Copy link
Contributor

nadalin commented Jan 17, 2018

@gmandyam will create PR

@nadalin nadalin assigned gmandyam and unassigned equalsJeffH Jan 17, 2018
@selfissued
Copy link
Contributor

@gmandyam can you please create the PR today or tomorrow morning so we can review it during the FIDO 2.0 meeting tomorrow? Thanks.

@gmandyam
Copy link

Addressed through #771

@selfissued
Copy link
Contributor

Can this be closed now that #771 has been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants