Add consideration of browser permissions framework for extension processing #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
reviewed
Jan 24, 2018
index.bs
Outdated
| ## Browser Permissions Framework and Extensions ## (#browser-permissions-framework-extensions) | ||
|
|
||
| The Web Authentication API should leverage the browser permissions framework as much as possible when obtaining user permissions for | ||
| certain extensions. An example is the location extrension, which can leverrage the existing browser permissions framework for the |
There was a problem hiding this comment.
Typos: "extrension" -> "extension", "leverrage" -> "leverage"
added 2 commits
January 24, 2018 08:56
|
@gmandyam please resolve the merge conflicts. Then I will merge the PR. |
selfissued
requested changes
Jan 31, 2018
| latitude: float64, | ||
| longitude: float64, | ||
| altitude: float64 | ||
| ] |
There was a problem hiding this comment.
An unrelated change appears to have been made in this PR. Please remove this extraneous change, as it will cause merge conflicts with other PRs.
|
PR #771 replaces this |
selfissued
pushed a commit
that referenced
this pull request
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #133
Preview | Diff