Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new name for Coordinates #1344

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Use the new name for Coordinates #1344

merged 1 commit into from
Dec 4, 2019

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Nov 18, 2019 •
edited by pr-preview bot
Loading

@saschanaz
Copy link
Member Author

Marked as non substantive for IPR from ash-nazg.

@nadalin nadalin requested review from agl and selfissued and removed request for equalsJeffH November 27, 2019 20:18
@equalsJeffH equalsJeffH self-requested a review November 27, 2019 20:18
@jcjones
Copy link
Contributor

jcjones commented Nov 27, 2019

Looks correct to me.

equalsJeffH
equalsJeffH approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agl
Copy link
Contributor

agl commented Dec 4, 2019

Last W3C-published draft is fairly old: https://www.w3.org/TR/geolocation-API/, but I guess that's why this PR references the editor's draft?

selfissued
selfissued approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should merge this. Separately, if we can refer to a W3C URL rather than a GitHub one, that would be preferable.

@selfissued selfissued merged commit 947b7bc into w3c:master Dec 4, 2019
WebAuthnBot pushed a commit that referenced this pull request Dec 4, 2019
Built by Travis-CI: 947b7bc Use the new name for Coordinates (#1344)
68744f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agl agl agl approved these changes

@equalsJeffH equalsJeffH equalsJeffH approved these changes

@selfissued selfissued selfissued approved these changes

Assignees

@equalsJeffH equalsJeffH

Labels
subtype:algorithms/WebIDL type:editorial type:technical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@saschanaz @jcjones @agl @equalsJeffH @selfissued @emlun