Remove ScopedCredentialParameters tuple (by unpairing type & algorithm) #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The procedure for normalizing algorithms and types doesn't actually use the types. Keeping these together in an object gives a kind of flexibility, but after consideration, I don't see much purpose in defining different algorithms for specifically different authenticator types. This changes the makeCredential() method to instead have a list of supported types and a list of supported algorithms, and perform its procedure that way.
Merged
|
Review comment from before: #142 (comment) |
| - The <dfn>cryptoParameters</dfn> parameter supplies information about the desired properties of the credential to be created. | ||
| The sequence is ordered from most preferred to least preferred. The platform makes a best effort to create the most | ||
| - The <dfn>supportedAlgorithms</dfn> and <dfn>supportedTypes</dfn> parameters supply information about the desired properties of the credential to be created. | ||
| The sequence is ordered from most preferred to least preferred. The platform makes a best effort to create the most logical and |
There was a problem hiding this comment.
what is meant by "most logical" in regards to a credential and its associated key pair?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The procedure for normalizing algorithms and types doesn't actually use the
types. Keeping these together in an object gives a kind of flexibility, but
after consideration, I don't see much purpose in defining different algorithms
for specifically different authenticator types.
This changes the makeCredential() method to instead have a list of supported
types and a list of supported algorithms, and perform its procedure that way.
This was part of PR #142, but per comments (#142 (comment) and #142 (comment)) is now its' own standalone PR. See prior discussion for background.