Remove TokenBinding #1630
Merged
Remove TokenBinding #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agl
approved these changes
Jun 17, 2021
|
Notes from call: Should mark TokenBinding as a reserved name within the ClientData |
selfissued
requested changes
Jun 30, 2021
added 2 commits
July 13, 2021 11:08
This reverts commit 5c4ce34.
ve7jtb
approved these changes
Jul 14, 2021
selfissued
reviewed
Jul 14, 2021
index.bs
Outdated
| with the [=[RP]=]. Its absence indicates that the client doesn't support token binding. | ||
| with the [=[RP]=]. Its absence indicates that the client doesn't support token binding | ||
|
|
||
| Note: While [=Token Binding=] was present in Level 1 and Level 2 of WebAuthn, it should not be expected to be present or supported in future versions of the specification. |
There was a problem hiding this comment.
Change "it should not be expected to be present or supported in future versions of the specification" to "its use is not expected in Level 3. The {{CollectedClientData/tokenBinding}} field is reserved so that it will not be reused for a different purpose."
selfissued
requested changes
Jul 14, 2021
selfissued
approved these changes
Jul 28, 2021
github-actions bot
added a commit
that referenced
this pull request
Jul 28, 2021
SHA: a30f8e8 Reason: push, by @nicksteele Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issues #1627 and #1623 along with what we discussed in the bi-weekly meeting. All references to
TokenBindinghave been removed from the document and IDLs, although I would be open to leaving a partial reference with a DEPRECATED flair in the ClientDataJSON section for posterity.Preview | Diff