Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address review comments by @sbweeden #1669

Merged
merged 1 commit into from Sep 20, 2021
Merged

Address review comments by @sbweeden #1669

merged 1 commit into from Sep 20, 2021

Conversation

emlun
Copy link
Member

@emlun emlun commented Sep 17, 2021 •
edited by pr-preview bot

@emlun emlun added type:editorial process:meta-pr Pull requests into other pull requests rather than main labels Sep 17, 2021
@emlun emlun added this to the L3-WD-01 milestone Sep 17, 2021
@emlun emlun requested a review from sbweeden September 17, 2021 15:35
@emlun emlun self-assigned this Sep 17, 2021
@emlun emlun mentioned this pull request Sep 17, 2021
Merged
sbweeden
sbweeden approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@sbweeden sbweeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emlun emlun merged commit 54e1a92 into issue-1618-clarify-params Sep 20, 2021
@emlun emlun deleted the issue-1618-review-sbweeden branch September 20, 2021 10:57
@emlun
Copy link
Member Author

emlun commented Sep 20, 2021

(Merged into PR #1621, not yet into main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbweeden sbweeden sbweeden approved these changes

Assignees

@emlun emlun

Labels
process:meta-pr Pull requests into other pull requests rather than main type:editorial
Projects
None yet
Milestone
L3-WD-01
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emlun @sbweeden