Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security consideration section "Validating the origin of a credential" #1930

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

emlun
Copy link
Member

@emlun emlun commented Jul 26, 2023

Fixes #1889.


Preview | Diff

Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emlun
Copy link
Member Author

emlun commented Jul 26, 2023

Thanks @timcappalli! I made another edit you may want to review. I'm not currently planning any more changes.

Copy link
Contributor

@nicksteele nicksteele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update lgtm

@nadalin nadalin added this to the L3-WD-01 milestone Aug 16, 2023
@emlun emlun merged commit 0a59b62 into main Aug 16, 2023
2 checks passed
@emlun emlun deleted the issue-1889-clarify-origin-matching branch August 16, 2023 18:10
github-actions bot added a commit that referenced this pull request Aug 16, 2023
SHA: 0a59b62
Reason: push, by emlun

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify how the given origin in the ClientDataJSON matches to the expected one
4 participants