Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks for bikeshed #1978

Closed
wants to merge 1 commit into from
Closed

Tweaks for bikeshed #1978

wants to merge 1 commit into from

Conversation

plehegar
Copy link
Member

@plehegar plehegar commented Sep 27, 2023 •
edited by pr-preview bot

emlun
emlun requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest rebasing onto main to resolve conflicts with the changes from PR #1975.

index.bs
@@ -1459,21 +1459,21 @@ The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "S

This section normatively specifies the API for creating and using [=public key credentials=]. The basic
idea is that the credentials belong to the user and are [=managing authenticator|managed=] by a [=[WAA]=], with which the [=[WRP]=] interacts through the [=client platform=]. [=[RP]=] scripts can (with the [=user consent|user's consent=]) request the
browser to create a new credential for future use by the [=[RP]=]. See <a href="#fig-registration">Figure <span class="figure-num-following"/></a>, below.
browser to create a new credential for future use by the [=[RP]=]. See <a href="#fig-registration">Figure <span class="figure-num-following"></a>, below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the changes below clash with the changes from PR #1975; I would suggest rebasing onto main. Looks like most or all of the changes from here on were obsoleted by #1975.

@plehegar plehegar marked this pull request as draft October 4, 2023 19:11
@plehegar plehegar self-assigned this Oct 4, 2023
@plehegar
Copy link
Member Author

plehegar commented Oct 4, 2023

Resubmitted in #1986

@plehegar plehegar closed this Oct 4, 2023
@emlun emlun deleted the bikeshed-tweaks branch October 4, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlun emlun emlun requested changes

Assignees

@plehegar plehegar

Labels
type:editorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@plehegar @emlun