Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference the Encoding spec's UTF-8 Encode definition #315

Merged
merged 2 commits into from
Jan 4, 2017
Merged

Reference the Encoding spec's UTF-8 Encode definition #315

merged 2 commits into from
Jan 4, 2017

Conversation

jcjones
Copy link
Contributor

@jcjones jcjones commented Dec 20, 2016

@jcjones jcjones added this to the WD-04 milestone Dec 20, 2016
@equalsJeffH equalsJeffH self-requested a review December 20, 2016 23:58
equalsJeffH
equalsJeffH approved these changes Dec 20, 2016
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @jcjones :)

@equalsJeffH
Copy link
Contributor

One aside to explicitly note here: referencing whatwg's encoding spec intersects with, and raises the spector of, our spec-referencing issue #257.

@equalsJeffH
Copy link
Contributor

One aside to explicitly note here: referencing whatwg's encoding spec intersects with, and raises the spector of, our spec-referencing issue #257.

Ah, there is now a W3C Encoding spec at CR maturity level -- https://www.w3.org/TR/encoding/ -- that we should reference per #257 (comment) and #257 (comment)

@jcjones
Copy link
Contributor Author

jcjones commented Jan 3, 2017

Rebased, and moved to the CR-maturity Encoding spec.

@equalsJeffH
Copy link
Contributor

LGTM

@jcjones jcjones merged commit e5c895f into w3c:master Jan 4, 2017
@jcjones jcjones deleted the kpaulh-master branch January 4, 2017 18:08
WebAuthnBot pushed a commit that referenced this pull request Jan 4, 2017
Built by Travis-CI: e5c895f Reference the Encoding spec's UTF-8 Encod…
425db17 
…e definition (#315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equalsJeffH equalsJeffH equalsJeffH approved these changes

Assignees

@jcjones jcjones

Labels
type:editorial
Projects
None yet
Milestone
WD-04
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcjones @equalsJeffH