Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omitted default abstract header #487

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Omitted default abstract header #487

merged 1 commit into from
Jun 14, 2017

Conversation

yackermann
Copy link
Contributor

@yackermann yackermann commented Jun 5, 2017

Default abstract header causes two abstract headers to appear.
issue

Added omit to boilerplate options.


Preview | Diff

@equalsJeffH
Copy link
Contributor

LGTM, thx!

@yackermann
Copy link
Contributor Author

@equalsJeffH happy to help*)

@equalsJeffH
Copy link
Contributor

AFAICT we should simply merge this.

@equalsJeffH
Copy link
Contributor

we may not actually "need" this because rendered spec that I gen using
curl https://api.csswg.org/bikeshed/ -F file=@index.bs -F force=1 > index.html
does not have double "Abstract" header, and neither does https://www.w3.org/TR/webauthn/

however I tested adding it and processing thru the above curl command and the "Abstract" header is rendered correctly so there is perhaps no downside to having it.

@equalsJeffH equalsJeffH self-assigned this Jun 9, 2017
Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it

@equalsJeffH equalsJeffH merged commit 119dd51 into w3c:master Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants