fix #254: credman alignment: update #getAssertion section a la PR #498 #665
Conversation
equalsJeffH
requested review from
jyasskin,
jcjones,
AngeloKai,
selfissued and
akshayku
| {{PublicKeyCredentialDescriptor}}.{{PublicKeyCredentialDescriptor/id}} and set its value to <code>|allowCredentialDescriptorList|[0].id</code>'s | ||
| value (see [here](#authenticatorGetAssertion-return-values) in [[#op-get-assertion]] for more information). | ||
|
|
||
| Issue: The foregoing step _may_ be incorrect, in that we are attempting to create |savedCredentialId| |
There was a problem hiding this comment.
We'll see what others think, but this is clear enough to me to be implementable. Practically speaking, tracking the CredentialId for whatever credential works is going to be done by the hardware interaction code -- either keeping track of which ID worked on the wire or getting back the ID that came on the wire. So it's really a matter of plumbing it out of that hardware code, not even necessarily of this algorithm defining an internal slot to keep track of it.
|
fixed conflicts with master, fixed issue #671. please review. |
|
should we go ahead and merge this, or wait for the f2f meeting at TPAC tomorrow? |
|
@akshayku @AngeloKai Can you both review ? @equalsJeffH if you get @akshayku and @AngeloKai to approve then merge |
|
I think it’s ok to merge this. |
This is intended to do what the subject says.
fix #671
fix #663
fix #661
fix #254 (finally)
Note: requisite mods to credman (w3c/webappsec-credential-management#100) remain in-progress
Preview (#createCreden…) (#discover-fro…) (#op-get-asser…) | Diff