Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #685 #686

Merged
merged 2 commits into from Dec 13, 2017
Merged

Fix issue #685 #686

merged 2 commits into from Dec 13, 2017

Conversation

emlun
Copy link
Member

@emlun emlun commented Nov 13, 2017 •
edited

See #685 . This is the suggested solution (2):

Move the 1st factor mode invocation branch to before filtering, and skip the authenticator completely if options.allowCredentials is nonempty and is known to not intersect with the credentials available on the authenticator.

Preview | Diff

@emlun emlun added this to the CR milestone Nov 13, 2017
@emlun emlun self-assigned this Nov 13, 2017
@equalsJeffH equalsJeffH self-requested a review December 6, 2017 18:51
@jcjones jcjones self-requested a review December 6, 2017 18:51
equalsJeffH
equalsJeffH approved these changes Dec 6, 2017
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @emlun ! Let's merge this.

@equalsJeffH
Copy link
Contributor

reviewed: #686 (review)
LGTM

@rlin1
Copy link
Contributor

rlin1 commented Dec 13, 2017

Looks good to me.

@emlun emlun mentioned this pull request Dec 13, 2017
Closed
@rlin1 rlin1 merged commit 269144c into master Dec 13, 2017
@rlin1
Copy link
Contributor

rlin1 commented Dec 13, 2017

as decided on today's call.

@emlun emlun deleted the issue-685 branch December 13, 2017 18:28
WebAuthnBot pushed a commit that referenced this pull request Dec 13, 2017
Built by Travis-CI: 269144c Fix issue #685 (#686)
17e9c6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equalsJeffH equalsJeffH equalsJeffH approved these changes

@jcjones jcjones Awaiting requested review from jcjones

Assignees

@emlun emlun

Labels
priority:implementation subtype:algorithms/WebIDL type:technical
Projects
None yet
Milestone
Last Working Draft
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emlun @equalsJeffH @rlin1