move the credentialId uniqueness handling to the formal alg steps. #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equalsJeffH
approved these changes
Dec 6, 2017
index.bs
Outdated
| 13. If the attestation statement |attStmt| verified successfully and is found to be trustworthy, then register the new | ||
| 1. Check that the <code>[=credentialId=]</code> is not yet registered to any other user. If registration | ||
| is requested for a credential that is already registered to a different user, the [=[RP]=] SHOULD | ||
| fail this ceremony, or it MAY decide to accept the registration, e.g. while deleting the older registration. |
There was a problem hiding this comment.
s/this ceremony /this [=registration=] ceremony /
|
reviewed: #709 (review) |
|
Just waiting for feedback from @AngeloKai |
|
Waiting for feedback from @akshayku instead. |
WebAuthnBot
pushed a commit
that referenced
this pull request
Dec 21, 2017
… to the formal alg steps. (#709)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #579
Preview | Diff