Terminology: WebAuthn Relying Party - no account creation #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed resolution for Issue #70
| @@ -2459,7 +2459,7 @@ | |||
|
|
|||
| : <dfn>Relying Party</dfn> | |||
| : <dfn>WebAuthn Relying Party</dfn> | |||
| :: The entity which needs to rely in the authentication provided by the WebAuthn specification. At the conclusion of the account creation, the Relying Party has the public key that was created by the Authenticator. | |||
| :: The entity which needs to rely in the authentication provided by the WebAuthn specification. At the conclusion of the registration, the Relying Party has the public key that was created by the Authenticator. | |||
There was a problem hiding this comment.
"At the conclusion of the registration" sounds weird. Can we say "When registration concludes", or if you want to link to the section on this, "When [[#registration-embedded]] concludes"?
Agreed & incorporated Vijay's recommendation.
| @@ -2459,7 +2459,7 @@ | |||
|
|
|||
| : <dfn>Relying Party</dfn> | |||
| : <dfn>WebAuthn Relying Party</dfn> | |||
| :: The entity which needs to rely in the authentication provided by the WebAuthn specification. At the conclusion of the registration, the Relying Party has the public key that was created by the Authenticator. | |||
| :: The entity which needs to rely in the authentication provided by the WebAuthn specification. When [[#registration-embedded]] concludes, the Relying Party has the public key that was created by the Authenticator. | |||
There was a problem hiding this comment.
Apologies for the noise, but I take this back. It might be better not to have the link here. This is how it now renders after Bikeshed processing:
When §1.1 Registration (embedded authenticator mode) concludes, the Relying Party has the public key that was created by the Authenticator.
May be better just to have the word "registration" instead of the link.
I've reverted to 'registration' - I still think the idea of referring to the Registration section is good. Is there a way to refer to it by section number and not section title?
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed resolution for Issue #70 (#70)