Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed uses of JSON string to USVString #739

Merged
merged 1 commit into from Jan 11, 2018

Conversation

selfissued
Copy link
Contributor

@selfissued selfissued commented Jan 10, 2018

Fixes #417


Preview | Diff

@selfissued selfissued added this to the CR milestone Jan 10, 2018
@selfissued selfissued self-assigned this Jan 10, 2018
@rlin1
Copy link
Contributor

rlin1 commented Jan 10, 2018

Is it this USVString: http://docs.w3cub.com/dom/usvstring/

@jcjones
Copy link
Contributor

jcjones commented Jan 10, 2018

@bzbarsky - can you confirm for us that USVString is what we should be using to pass user-supplied textual strings around?

@bzbarsky
Copy link

Does "user" mean "actual person sitting at a keyboard"?

If so, then I'd think USVString is a reasonable option. @annevk may have better guidance somewhere, apart from whatever is at https://heycam.github.io/webidl/#idl-USVString

If you plan to pass the string to someone who expects "Unicode text", then USVString is a good idea.

@annevk
Copy link
Member

annevk commented Jan 10, 2018

I think that's it. We also have https://infra.spec.whatwg.org/#strings but it doesn't mention IDL types (at some point IDL will be rewritten in terms of Infra at which point it'll reference all of that).

@selfissued selfissued merged commit ade8321 into w3c:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants