Strongly type client extension inputs and outputs #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The type |
|
The |
|
@agl can you please approve this PR now that the unused typedef has been removed? Thanks. |
emlun
approved these changes
Jan 31, 2018
index.bs
Outdated
| :: Returns a JSON array of 3-element arrays of numbers that encodes the factors in the authenticator extension output. | ||
| <xmp class="idl"> | ||
| typedef sequence<unsigned long> uvmEntry; | ||
| typedef sequence<uvmEntry> uvmEntries; |
There was a problem hiding this comment.
Nit: Should these typedefs' names also have initial uppercase like the others?
There was a problem hiding this comment.
Done. Thanks for the careful read @emlun .
|
I concur with agl, this looks good to me as well. |
agl
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client extension inputs and outputs are now strongly typed. Several individual extensions were also cleaned up so that their JavaScript and CBOR representations directly correspond to one another. The example extension was so irregular and ad-hoc as to actually be a terrible example. It was therefore deleted. The existing extensions now should serve as good examples.
Fixes #346
Fixes #626
Partially fixes #713
Partially fixes #738
Preview | Diff