-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-ASCII RP display name example #825
Add non-ASCII RP display name example #825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The name Romanovskaya Robotics seems harmless enough. Ideally, we should have a native Russian speaker like @leshi also review this.
I did run it by a Russian speaking friend of mine, but yes, I agree. I welcome any suggestions for changes. |
(The particular name was the first alliterated example that sprung to my mind when thinking about making a Cyrillic one) |
What I'm not qualified to review is the Russian gender matching rules. I believe that adjective could either be Романовская (Romanovskaya) or Романовскый (Romanovskiy), depending upon the gender of Робототехника. |
Side note: given that a Unicode character could require up to 4 bytes when encoded in UTF-8, the 64-byte minimum length for a name member's value could limit a relying party name to 16 Unicode characters. Is that enough? (My sense is: probably.) |
@emlun Despite the fact that "Романовская Робототехник" is grammatically correct, practically it sounds pretty weird(sounds like something from 18th century). Probably better example "ОАО Примертех", "ГО Башпром", "Авиапути Диксона" |
Are the names you're proposing real or clearly fictional, @herrjemand ? They have to be clearly fictional to include in the specification, or trademark usage issues could arise. Thanks. |
"ОАО Примертех" - translates as OAO Exampletech All fictional |
"ОАО Примертех" - translates as OAO Exampletech |
Great, I'll change to that one then. Thanks! |
Happy to help @emlun *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for ОАО Примертех
* Add non-ASCII RP display name example * Change Cyrillic RP name example as recommended by @herrjemand
Fixes #594.
Preview | Diff