Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-ASCII RP display name example #825

Merged
merged 2 commits into from
Mar 28, 2018

Conversation

emlun
Copy link
Member

@emlun emlun commented Feb 28, 2018

Fixes #594.


Preview | Diff

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The name Romanovskaya Robotics seems harmless enough. Ideally, we should have a native Russian speaker like @leshi also review this.

@selfissued selfissued added this to the PR milestone Feb 28, 2018
@emlun
Copy link
Member Author

emlun commented Feb 28, 2018

I did run it by a Russian speaking friend of mine, but yes, I agree. I welcome any suggestions for changes.

@emlun
Copy link
Member Author

emlun commented Feb 28, 2018

(The particular name was the first alliterated example that sprung to my mind when thinking about making a Cyrillic one)

@selfissued
Copy link
Contributor

What I'm not qualified to review is the Russian gender matching rules. I believe that adjective could either be Романовская (Romanovskaya) or Романовскый (Romanovskiy), depending upon the gender of Робототехника.

@stpeter
Copy link

stpeter commented Feb 28, 2018

Side note: given that a Unicode character could require up to 4 bytes when encoded in UTF-8, the 64-byte minimum length for a name member's value could limit a relying party name to 16 Unicode characters. Is that enough? (My sense is: probably.)

@yackermann
Copy link
Contributor

yackermann commented Mar 7, 2018

@emlun Despite the fact that "Романовская Робототехник" is grammatically correct, practically it sounds pretty weird(sounds like something from 18th century). Probably better example "ОАО Примертех", "ГО Башпром", "Авиапути Диксона"

@selfissued
Copy link
Contributor

Are the names you're proposing real or clearly fictional, @herrjemand ? They have to be clearly fictional to include in the specification, or trademark usage issues could arise. Thanks.

@yackermann
Copy link
Contributor

"ОАО Примертех" - translates as OAO Exampletech
"РомРобСис - Романовские Робототехнические Системы" - Romanovsk Robotech systems
"ГО Ненецкие Авиалинии" - Nentsk Airlines

All fictional

@yackermann
Copy link
Contributor

"ОАО Примертех" - translates as OAO Exampletech
Probably the best one I could come up with

@emlun
Copy link
Member Author

emlun commented Mar 7, 2018

"ОАО Примертех" - translates as OAO Exampletech
Probably the best one I could come up with

Great, I'll change to that one then. Thanks!

@yackermann
Copy link
Contributor

Happy to help @emlun *)

Copy link
Contributor

@leshi leshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ОАО Примертех

@equalsJeffH equalsJeffH merged commit 0e29880 into w3c:master Mar 28, 2018
@emlun emlun deleted the non-ascii-rp-displayname-example branch March 28, 2018 17:36
kpaulh pushed a commit to kpaulh/webauthn that referenced this pull request Apr 6, 2018
* Add non-ASCII RP display name example

* Change Cyrillic RP name example as recommended by @herrjemand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants