Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an example for aborting operations #847

Merged
merged 2 commits into from
Mar 30, 2018
Merged

Fix an example for aborting operations #847

merged 2 commits into from
Mar 30, 2018

Conversation

Kieun
Copy link
Member

@Kieun Kieun commented Mar 18, 2018 •
edited by pr-preview bot
Loading

This PR resolves the #844. We need to use abort function of AbortController object instead of AbortSignal to invoke abort operations.

Preview | Diff

@Kieun
Copy link
Member Author

Kieun commented Mar 18, 2018

Marked as non substantive for IPR from ash-nazg.

@Kieun Kieun changed the title Abort conroller Fix an example for aborting operations Mar 18, 2018
@Kieun
Copy link
Member Author

Kieun commented Mar 27, 2018

@emlun please review this PR.

equalsJeffH
equalsJeffH approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx Kieun!

@equalsJeffH
Copy link
Contributor

this is just corrects an error in the Aborting Authn Ops example.

@nadalin nadalin added this to the PR milestone Mar 28, 2018
@nadalin nadalin requested a review from jcjones March 28, 2018 17:47
jcjones
jcjones approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@jcjones jcjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is correct. Good catch! Thanks!

@jcjones jcjones merged commit eb49aad into w3c:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equalsJeffH equalsJeffH equalsJeffH approved these changes

@jcjones jcjones jcjones approved these changes

Assignees

@Kieun Kieun

Labels
None yet
Projects
None yet
Milestone
PropRec
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kieun @equalsJeffH @jcjones @nadalin