Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recommendation of challenge length #858

Merged
merged 2 commits into from
Apr 16, 2018
Merged

Add recommendation of challenge length #858

merged 2 commits into from
Apr 16, 2018

Conversation

emlun
Copy link
Member

@emlun emlun commented Apr 4, 2018 •
edited by pr-preview bot
Loading

This fixes #85.

Preview | Diff

@emlun emlun added type:editorial security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. labels Apr 4, 2018
@emlun emlun added this to the PR milestone Apr 4, 2018
@emlun emlun self-assigned this Apr 4, 2018
@emlun emlun requested a review from equalsJeffH April 4, 2018 12:57
@emlun emlun mentioned this pull request Apr 4, 2018
Closed
selfissued
selfissued approved these changes Apr 11, 2018
View reviewed changes
Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@selfissued
Copy link
Contributor

@equalsJeffH to merge if it looks good to him.

equalsJeffH
equalsJeffH approved these changes Apr 16, 2018
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@equalsJeffH equalsJeffH merged commit b9af923 into master Apr 16, 2018
WebAuthnBot pushed a commit that referenced this pull request Apr 16, 2018
Built by Travis-CI: b9af923 Add recommendation of challenge length (#858
aabdf82 
)
@emlun emlun deleted the issue-85-challenge-recommendations branch April 24, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equalsJeffH equalsJeffH equalsJeffH approved these changes

@selfissued selfissued selfissued approved these changes

@akshayku akshayku akshayku approved these changes

Assignees

@emlun emlun

Labels
security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. type:editorial
Projects
None yet
Milestone
PropRec
Development

Successfully merging this pull request may close these issues.

assertionChallenge recommendations
4 participants
@emlun @selfissued @equalsJeffH @akshayku