Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt definition list markdown notation for dfn blocks #901

Merged
merged 8 commits into from
Jun 6, 2018
Merged

Adopt definition list markdown notation for dfn blocks #901

merged 8 commits into from
Jun 6, 2018

Conversation

emlun
Copy link
Member

@emlun emlun commented May 9, 2018 •
edited by pr-preview bot
Loading

This fixes #405.

Preview | Diff

@emlun emlun added this to the PropRec milestone May 9, 2018
@emlun emlun self-assigned this May 9, 2018
@emlun emlun requested a review from equalsJeffH May 9, 2018 17:57
jcjones
jcjones approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@jcjones jcjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It'll need a rebase, but I don't see any typos.

@emlun
Copy link
Member Author

emlun commented May 16, 2018

#914 will conflict with this; I'll update this after #914 is merged.

selfissued
selfissued approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will improve the readability of the specification. We should merge this soon, as time will be needed for the resulting merge conflicts with other PRs to be resolved.

@emlun emlun mentioned this pull request May 29, 2018
Merged
@nadalin
Copy link
Contributor

nadalin commented Jun 5, 2018

@emlun please merge

@emlun emlun merged commit 0f5b3a8 into master Jun 6, 2018
@emlun emlun deleted the issue-405-dfn-blocks branch June 6, 2018 05:09
WebAuthnBot pushed a commit that referenced this pull request Jun 6, 2018
Built by Travis-CI: 0f5b3a8 Merge pull request #901 from w3c/issue-40…
b9721b5 
…5-dfn-blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcjones jcjones jcjones approved these changes

@selfissued selfissued selfissued approved these changes

@equalsJeffH equalsJeffH Awaiting requested review from equalsJeffH

Assignees

@emlun emlun

Labels
type:editorial
Projects
None yet
Milestone
PropRec
Development

Successfully merging this pull request may close these issues.

adopt definition list markdown notation for <div dfn-type="foo" dfn-for="bar"> blocks
4 participants
@emlun @nadalin @jcjones @selfissued