-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for changing metadata #161
Comments
Having the capability to do this would be very useful. With copy-on-write semantics your API suggestion sounds fine in terms of performance, but maybe a bit unfamiliar to developers. |
Triage note: marked 'extension' as the proposal is describing adding new arguments to a method. |
I tend to agree in practice, but this is breaking in theory ( |
Note: now that we support construction from a I think it may be surprising that this construction clones rather than copies, but the spec is already quite clear on this point. Maybe we don't actually need |
@sandersdan what are your feelings as of late? Do you want to see metadata overrides added to clone() or is the VideoFrame constructor option sufficient? I can see it either way (i.e. symmetry is nice, but argument could also be made that clone() is the "simple" option). |
I no longer feel strongly about I suppose there is also the inverse to consider, an option for |
Ok, lets close this for now. If we hear folks hate the current options we'll reconsider. |
An app may have a frame (video or audio) but want to change its metadata (timestamp, duration, colorspace) before passing it to another component. I propose that we extend
clone()
to take an initialization dictionary that allows this metadata to be overwritten in the clone. It would probably make sense for any introducedcopy()
API to do the same.The text was updated successfully, but these errors were encountered: