Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse WebCodec audio/video chunk definitions #101

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

youennf
Copy link
Collaborator

@youennf youennf commented Apr 15, 2021

Initial try at fixing #99


Preview | Diff

@youennf youennf added the WIP label Apr 15, 2021
@dontcallmedom dontcallmedom marked this pull request as draft April 15, 2021 09:52
readonly attribute ArrayBuffer data;
};

// WebCodecs definitions with introduction of EncodedMediaChunk to more easily refer to timestamp and data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be brought directly back to WebCodecs?

Copy link
Collaborator Author

@youennf youennf Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer we get agreement on the strategy first, like get agreement to reuse WebCodecs constructs, then start discussing with WebCodecs how we can best do things.
With regards to EncodedMediaChunk, I did not think about it to hard, we might want to use a mixin instead of inheritance.

"empty",
interface mixin EncodedMediaChunk {
readonly attribute unsigned long long timestamp; // microseconds
readonly attribute ArrayBuffer data;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I look at it, data is readonly here but we want to be able to change it in RTCRtpSFrameTransform transforms.

@alvestrand alvestrand requested a review from guidou April 15, 2021 14:14
@youennf
Copy link
Collaborator Author

youennf commented Apr 15, 2021

Discussed with @aboba, and the plan might be to remove all encoded audio/video frames but leave RTP metadata specific bits, for instance as partial dictionaries.

@aboba
Copy link
Contributor

aboba commented Apr 15, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants