-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opus configuration (e.g. in-band fec) #244
Comments
That's a registry type thing isn't it. Maybe we should tag those. |
Editors Call: from list above, FEC and DTX are the most important used in WebRTC SDP currently. Complexity defaults to 9. |
Cisco / Webex folks mentioned lack of complexity option (present in @aboba's earlier link) is hurting CPU perf for their use case. |
Timeline: lets spec this in the current quarter (Q2). Real users + low hanging fruit. |
folks, is there any update? |
@tguilbert-google in case this ends up getting discussed at TPAC this week. |
My proposal would be to expand the OpusEncoderConfig to include these parameters. This is very similar to #371, which is scheduled to be discussed tomorrow; assuming no pushback, I would also edit the spec to include these extra parameters. I don't know which parameters we'd want to add from the ones linked by @aboba above. There is a lot of demand for adding |
I think FEC, DTX, and complexity are the ones to add given the editors consensus above. Others can come later as you say. |
Hi, I think some version of OPUS_SET_PACKET_LOSS_PERC needs to be accessible if FEC is going to be enabled: |
Thanks @sdanahy2, that is also relevant for FEC. See #594 |
in issue #9 @murillo128 requested a way to configure opus in-band fec.
https://www.opus-codec.org/docs/html_api/group__encoderctls.html#ga5b67dc832aa46c1c2f35752c46380545
The text was updated successfully, but these errors were encountered: