Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opus configuration (e.g. in-band fec) #244

Closed
chcunningham opened this issue May 12, 2021 · 11 comments · Fixed by #594
Closed

opus configuration (e.g. in-band fec) #244

chcunningham opened this issue May 12, 2021 · 11 comments · Fixed by #594
Assignees
Labels
extension Interface changes that extend without breaking. PR exists A PR has been submitted that addresses this issue

Comments

@chcunningham
Copy link
Collaborator

in issue #9 @murillo128 requested a way to configure opus in-band fec.

https://www.opus-codec.org/docs/html_api/group__encoderctls.html#ga5b67dc832aa46c1c2f35752c46380545

@chcunningham chcunningham added the extension Interface changes that extend without breaking. label May 12, 2021
@padenot
Copy link
Collaborator

padenot commented May 17, 2021

That's a registry type thing isn't it. Maybe we should tag those.

@aboba
Copy link
Collaborator

aboba commented May 18, 2021

Yes. Here is a list of other potential Opus configuration settings.

Also: https://datatracker.ietf.org/doc/html/rfc7587#section-6.1

@aboba aboba changed the title opus in-band fec opus configuration (e.g. in-band fec) Jul 7, 2021
@chcunningham
Copy link
Collaborator Author

Editors Call: from list above, FEC and DTX are the most important used in WebRTC SDP currently. Complexity defaults to 9.

@chcunningham
Copy link
Collaborator Author

Cisco / Webex folks mentioned lack of complexity option (present in @aboba's earlier link) is hurting CPU perf for their use case.

@chcunningham
Copy link
Collaborator Author

Timeline: lets spec this in the current quarter (Q2). Real users + low hanging fruit.

@JSmith01
Copy link

folks, is there any update?

@dalecurtis
Copy link
Contributor

@tguilbert-google in case this ends up getting discussed at TPAC this week.

@tguilbert-google
Copy link
Member

My proposal would be to expand the OpusEncoderConfig to include these parameters. This is very similar to #371, which is scheduled to be discussed tomorrow; assuming no pushback, I would also edit the spec to include these extra parameters.

I don't know which parameters we'd want to add from the ones linked by @aboba above. There is a lot of demand for adding useinbandfec, but are there any other obvious candidates? Keeping in mind that it is always easier to add parameters than to remove them.

@dalecurtis
Copy link
Contributor

I think FEC, DTX, and complexity are the ones to add given the editors consensus above. Others can come later as you say.

@sdanahy
Copy link

sdanahy commented Sep 28, 2022

Hi, I think some version of OPUS_SET_PACKET_LOSS_PERC needs to be accessible if FEC is going to be enabled:

https://draft.ortc.org/#dfn-packetlossperc

@tguilbert-google
Copy link
Member

Thanks @sdanahy2, that is also relevant for FEC. See #594

@aboba aboba added the PR exists A PR has been submitted that addresses this issue label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Interface changes that extend without breaking. PR exists A PR has been submitted that addresses this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants