Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hardware acceleration configurable. #118

Merged
merged 10 commits into from
Feb 23, 2021
Merged

Make hardware acceleration configurable. #118

merged 10 commits into from
Feb 23, 2021

Conversation

chcunningham
Copy link
Collaborator

@chcunningham chcunningham commented Dec 21, 2020 •
edited by pr-preview bot
Loading

Fixes #75.

Preview | Diff

@chcunningham chcunningham linked an issue Dec 21, 2020 that may be closed by this pull request
Require hardware acceleration #75
Closed
@chcunningham
Define static async isConfigSupported()
569f64f 
Earlier drafts wrongly assumed that support could be determined
synchronously.This remedies that by introducing a new async API
to check support prior to calling configure().

Fixes #98. See additional discussion there.
@chcunningham
Add parsed config to the returne of isConfigSupported()
dc8fea2 
Similar to MediaCapabilities and EME specs, the isConfigSupported()
promise will now include the configuration who's support is described.
This helps feature detect when parts of the input configuration
dictionary are ignored (when the UA implementation lags behind the
specification).
@chcunningham
Merge pull request #117 from WICG/avc_encoder_config
2d2f06b 
Add AvcEncoderConfig to specify optional annex-b format.
padenot
padenot reviewed Feb 17, 2021
View reviewed changes
Copy link
Collaborator

@padenot padenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks good. Maybe adding an informative note to explain the usefulness of this (it's not obvious), and I'm not sure about the name acceleration, it doesn't mention "hardware" acceleration. Maybe simply hardwareAcceleration ?

index.src.html Outdated Show resolved Hide resolved
chcunningham
chcunningham commented Feb 18, 2021
View reviewed changes
Copy link
Collaborator Author

@chcunningham chcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding an informative note to explain the usefulness of this (it's not obvious)

Done

and I'm not sure about the name acceleration, it doesn't mention "hardware" acceleration. Maybe simply hardwareAcceleration ?

Done

index.src.html Outdated Show resolved Hide resolved
@chcunningham chcunningham mentioned this pull request Feb 19, 2021
Closed
@chcunningham
Copy link
Collaborator Author

@padenot I'll go ahead with this merge and address any follow up feedback when you return.

@chcunningham chcunningham merged commit ac95fd0 into avc_encoder_config Feb 23, 2021
@chcunningham chcunningham deleted the configure_acceleration branch March 24, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padenot padenot padenot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require hardware acceleration
2 participants
@chcunningham @padenot