Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WCG color spaces. #566

Merged
merged 1 commit into from Oct 19, 2022
Merged

Add WCG color spaces. #566

merged 1 commit into from Oct 19, 2022

Conversation

sandersdan
Copy link
Contributor

@sandersdan sandersdan commented Sep 26, 2022

This implements the color spaces portion of #384, but does not add pixel formats or HDR metadata.


Preview | Diff

"iec61966-2-1",
"linear",
"pq",
"hlg",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative names here are "smpte2084" and "arib-std-b67", which would align with FFmpeg naming.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK as is, but if you're considering changing, I'd suggest referencing BT2100, so something like bt2100-2-pq and bt2100-2-hlg.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that more legible? Even Wikipedia just calls it PQ/HLG.

Copy link
Member

@chrisn chrisn Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, my preference is for pq and hlg

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great :) I think Dan was just playing devils advocate above.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see! My comment was really: if you're going in that direction, prefer BT.2100 rather than the SMPTE and ARIB standards.

@chrisn
Copy link
Member

chrisn commented Sep 26, 2022

Should we align these with Media Capabilities ColorGamut and TransferFunction? Are there cases where WebCodecs needs a different set of possible values than Media Capabilities?

@sandersdan
Copy link
Contributor Author

sandersdan commented Sep 26, 2022

Should we align these with Media Capabilities ColorGamut and TransferFunction?

The short answer is that we diverged with the first version of WebCodecs, which we decided was acceptable since WebCodecs does not integrate with MediaCapabilities. Some of the values I picked in this PR do match between the two, at least.

Perhaps more relevant is alignment with https://github.com/w3c/ColorWeb-CG/blob/master/hdr_html_canvas_element.md, but that is not yet finalized and also has a different technical interpretation.

Copy link
Contributor

@dalecurtis dalecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names lgtm since we're using what's named in H.273.

@dalecurtis
Copy link
Contributor

Any last comments on these names? It's been 3 weeks, so we'll go ahead and merge tomorrow otherwise.

Copy link
Member

@chrisn chrisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalecurtis, sorry for the delay. I left one minor comment to consider, but otherwise looks good.

@dalecurtis dalecurtis merged commit 34b6ed2 into main Oct 19, 2022
@dalecurtis dalecurtis deleted the wcg branch October 19, 2022 20:28
@dalecurtis
Copy link
Contributor

Thanks all. I think we have sufficient approval to merge now.

github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Oct 19, 2022
SHA: 34b6ed2
Reason: push, by tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 22, 2022
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants