Add OpusEncoderConfig.[signal/application] #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tguilbert-google
commented
Mar 5, 2024
opus_codec_registration.src.html
Outdated
| @@ -46,6 +46,12 @@ | |||
| "title": "RFC 7845: Ogg Encapsulation for the Opus Audio Codec", | |||
| "publisher": "IETF", | |||
| "date": "April 2016" | |||
| }, | |||
| "OBJECT-RTC": { | |||
There was a problem hiding this comment.
I'm not sure if we're allowed to reference this, considering the draft status? I also don't know if WebCodecs wants to take a "dependency" here too.
There was a problem hiding this comment.
I would keep the reference non-normative. Or you can just copy the text, not have a reference at all and add an acknowledgement citing ORTC.
opus_codec_registration.src.html
Outdated
| </pre> | ||
|
|
||
| The {{OpusSignal}} describes the type of audio signal being encoded. See | ||
| [secion 9.3.1.1](https://draft.ortc.org/#opus-codec-options*) of [[OBJECT-RTC]]. |
There was a problem hiding this comment.
Again, I'm not sure if referencing that section is allowed and adds much. The signal and application parameters are not defined with a lot of details there.
There was a problem hiding this comment.
I would keep the reference non-normative. Or you can just copy the text, not have a reference at all and add an acknowledgement citing ORTC.
| @@ -115,6 +121,8 @@ | |||
| <xmp> | |||
| dictionary OpusEncoderConfig { | |||
| OpusBitstreamFormat format = "opus"; | |||
| OpusSignal signal = "auto"; | |||
| OpusApplication application = "audio"; | |||
There was a problem hiding this comment.
There is no default in libopus for OPUS_SET_APPLICATION (unlike the default of "auto" for OPUS_SET_SIGNAL). I think "audio" is the most generic/least surprising as a default.
padenot
approved these changes
Mar 11, 2024
aboba
approved these changes
Mar 11, 2024
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2024
SHA: a5e076e Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 23, 2024
This CL adds optional configuration flags to the OpusEncoderConfig. See matching spec change: w3c/webcodecs#777 Bug: 330949853 Change-Id: Iaa39ba0a710ffb482aa767deb8992f67c52ebb93
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 15, 2024
This CL adds optional configuration flags to the OpusEncoderConfig. See matching spec change: w3c/webcodecs#777 Bug: 330949853 Change-Id: Iaa39ba0a710ffb482aa767deb8992f67c52ebb93
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 16, 2024
This CL adds optional configuration flags to the OpusEncoderConfig. See matching spec change: w3c/webcodecs#777 Bug: 330949853 Change-Id: Iaa39ba0a710ffb482aa767deb8992f67c52ebb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5387232 Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/main@{#1288112}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 16, 2024
This CL adds optional configuration flags to the OpusEncoderConfig. See matching spec change: w3c/webcodecs#777 Bug: 330949853 Change-Id: Iaa39ba0a710ffb482aa767deb8992f67c52ebb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5387232 Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/main@{#1288112}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 16, 2024
This CL adds optional configuration flags to the OpusEncoderConfig. See matching spec change: w3c/webcodecs#777 Bug: 330949853 Change-Id: Iaa39ba0a710ffb482aa767deb8992f67c52ebb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5387232 Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/main@{#1288112}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 23, 2024
…n], a=testonly Automatic update from web-platform-tests Add OpusEncoderConfig.[signal/application] This CL adds optional configuration flags to the OpusEncoderConfig. See matching spec change: w3c/webcodecs#777 Bug: 330949853 Change-Id: Iaa39ba0a710ffb482aa767deb8992f67c52ebb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5387232 Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/main@{#1288112} -- wpt-commits: 911ae4d05e14feedfe20fb0e83597ad485b77d10 wpt-pr: 45290
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Apr 24, 2024
…n], a=testonly Automatic update from web-platform-tests Add OpusEncoderConfig.[signal/application] This CL adds optional configuration flags to the OpusEncoderConfig. See matching spec change: w3c/webcodecs#777 Bug: 330949853 Change-Id: Iaa39ba0a710ffb482aa767deb8992f67c52ebb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5387232 Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/main@{#1288112} -- wpt-commits: 911ae4d05e14feedfe20fb0e83597ad485b77d10 wpt-pr: 45290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up work for #759.
AudioEncoderConfig.contenHintwas not added, since only the Opus codec would benefit from it. Instead, we favored adding the individual codec configuration parameters directly to the Opus registry.This PR adds
OpusEncoderConfig.signalandOpusEncoderConfig.application.