Update RSA and ECDH export steps and OIDs #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2021
sideshowbarker
approved these changes
Jan 16, 2022
panva
added a commit
to panva/node
that referenced
this pull request
Apr 21, 2022
panva
added a commit
to panva/node
that referenced
this pull request
May 18, 2022
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
May 25, 2022
closes #39959 see w3c/webcrypto#307 see w3c/webcrypto#305 PR-URL: #42816 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
bengl
pushed a commit
to nodejs/node
that referenced
this pull request
May 30, 2022
closes #39959 see w3c/webcrypto#307 see w3c/webcrypto#305 PR-URL: #42816 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 12, 2022
closes #39959 see w3c/webcrypto#307 see w3c/webcrypto#305 PR-URL: #42816 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 31, 2022
closes #39959 see w3c/webcrypto#307 see w3c/webcrypto#305 PR-URL: #42816 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
littledivy
pushed a commit
to denoland/deno
that referenced
this pull request
Oct 4, 2022
This PR updates RSA key import/export to a state which is interoperable with other implementations. For RSA the only OID in and out is `rsaEncryption`. For EC the only OID in and out is `id-ecpublickey` (fixed in #16152). see w3c/webcrypto#307 (comment) see w3c/webcrypto#307 see w3c/webcrypto#305 see nodejs/node#42816
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
closes #39959 see w3c/webcrypto#307 see w3c/webcrypto#305 PR-URL: nodejs/node#42816 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the RSA and ECDH spki and pkcs8 export steps and OIDs to match the behavior of all tested implementations:
id-RSASSA-PSStorsaEncryption(even though RSA-PSS is a signing algorithm, which is unfortunate, but the same is already true for RSASSA-PKCS1-v1_5 - and it seems all underlying crypto libraries use thersaEncryptionOID in all cases, leading to this behavior in all implementations)id-RSAES-OAEPtorsaEncryptionid-ecDHtoid-ecPublicKeyFixes #300.
Preview | Diff