Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"browsingContext.print" with custom scaling should not use default value (true) of "shrinkToFit" argument #686

Open
whimboo opened this issue Mar 11, 2024 · 0 comments
Labels
browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group

Comments

@whimboo
Copy link
Contributor

whimboo commented Mar 11, 2024

Right now the shrinkToFit argument of the browsingContext.print command defaults to true. That even when a client specified the scale argument with a different value than 1. As result in Firefox the scaling is not applied at all.

When I check the print options of Safari I can see that Scale to fit paper size doesn't have any effect when a scaling value is set. Also Chrome behaves that way when using the system print dialog on MacOS. In it's own UI a Shrink to Fit option is not even visible. And in Firefox Shrink to Fit and Scale are options that are mutual exclusive.

Should we consider not applying shrinkToFit when scale has a custom value?

Note that this will also apply to WebDriver classic, and would require a separate PR.

CC @gsnedders @sadym-chromium, @jgraham

@whimboo whimboo changed the title "browsingContext.print "browsingContext.print" with custom scaling should not use default value (true) of "shrinkToFit" argument Mar 11, 2024
@whimboo whimboo added browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group
Projects
None yet
Development

No branches or pull requests

1 participant