Extend roadmap: device emulation #420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
whimboo
requested changes
May 15, 2023
whimboo
requested changes
Jun 16, 2023
roadmap.md
Outdated
|
|
||
| This scenario allows to emulate a device, e.g. a mobile phone, and its capabilities, e.g. screen size and pixel density. In spec terms, this involves: | ||
| - [x] Some items from the previous milestones | ||
| - [ ] [Emulating width, height, deviceScaleFactor of the view port](https://github.com/w3c/webdriver-bidi/issues/415) |
There was a problem hiding this comment.
As per #415 (comment) the deviceScaleFactor has been moved out for now. Maybe you can add it as a separate item to this list? I don't think that an issue exists yet for it.
OrKoN
reviewed
Jun 16, 2023
|
Also please move it out of draft mode if you think that the patch is ready. |
Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
whimboo
reviewed
Jun 23, 2023
| @@ -95,5 +95,5 @@ This scenario loads a web page and prints it as a PDF. In spec terms, this invol | |||
|
|
|||
| This scenario allows to emulate a device, e.g. a mobile phone, and its capabilities, e.g. screen size and pixel density. In spec terms, this involves: | |||
| - [x] Some items from the previous milestones | |||
| - [ ] [Emulating width, height, deviceScaleFactor of the view port](https://github.com/w3c/webdriver-bidi/issues/415) | |||
| - [ ] [Changing the viewport width and height](https://github.com/w3c/webdriver-bidi/issues/415) | |||
There was a problem hiding this comment.
I think that we should still keep the deviceScaleFactor in this list but just as another item. Maybe you can file an issue for that so it can directly be linked?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend roadmap with "device emulation" scenario.
Proposal for #403.