Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognised WebIDL tokens since d50bdf0 #1181

Closed
andreastt opened this issue Jan 5, 2018 · 5 comments
Closed

Unrecognised WebIDL tokens since d50bdf0 #1181

andreastt opened this issue Jan 5, 2018 · 5 comments
Labels

Comments

@andreastt
Copy link
Member

Following #1176 we are seeing two errors from ReSpec to do with WebIDL:

Navigator includes NavigatorAutomationInformation;

 Unrecognised tokens, line 1 (tokens: 'Navigator includes NavigatorAutomationInformation')
[
    {
        "type": "identifier",
        "value": "Navigator"
    },
    {
        "type": "whitespace",
        "value": " "
    },
    {
        "type": "identifier",
        "value": "includes"
    },
    {
        "type": "whitespace",
        "value": " "
    },
    {
        "type": "identifier",
        "value": "NavigatorAutomationInformation"
    }
]
interface mixin NavigatorAutomationInformation {
readonly attribute boolean webdriver; // always returns true
};

 Bodyless interface, line 1 (tokens: 'NavigatorAutomationInformation {
 readonly')
[
    {
        "type": "identifier",
        "value": "NavigatorAutomationInformation"
    },
    {
        "type": "whitespace",
        "value": " "
    },
    {
        "type": "other",
        "value": "{"
    },
    {
        "type": "whitespace",
        "value": "\n "
    },
    {
        "type": "identifier",
        "value": "readonly"
    }
]

cc @romandev

@andreastt andreastt added the bug label Jan 5, 2018
@romandev
Copy link
Member

romandev commented Jan 5, 2018

Oh, it seems to have to update in ReSpec side: https://github.com/w3c/respec/issues/1423
Looking into the issue, @marcoscaceres seems to have already implemented it.

@andreastt
Copy link
Member Author

andreastt commented Jan 5, 2018

Was that the correct paste? Perhaps @marcoscaceres can shed some light on this.

@romandev
Copy link
Member

romandev commented Jan 6, 2018

Ah, sorry. I updated the link: https://github.com/w3c/respec/issues/1423

@marcoscaceres
Copy link
Member

I’m currently on vacation, but will try to take a look soon. I can’t recall if the current version WebIDL2.js I ship with ReSpec supports mixins.

@saschanaz
Copy link
Member

Glad to tell the new ReSpec 19.1.1 fixes this 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants