Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not all commands invoke the user prompt handler #1359

Open
thejohnjansen opened this issue Nov 8, 2018 · 0 comments
Open

not all commands invoke the user prompt handler #1359

thejohnjansen opened this issue Nov 8, 2018 · 0 comments

Comments

@thejohnjansen
Copy link
Contributor

In issue 1086 (Element retrieval commands do not invoke the user prompt handler) we covered the TPAC decision to review all endpoints regarding Elements; however, we missed additional commands that should also invoke user prompt handler.

This issue is meant to cover the additional areas of the spec, such as Take Screenshot and Take Element Screenshot (as well as any other commands necessary)

kisg pushed a commit to paul99/webkit-mips that referenced this issue Jan 10, 2019
…ands as failure

Tests don't expect user prompts to be handled in take screenshot commands, but that's going to change in the
spec soon, see w3c/webdriver#1359.

* TestExpectations.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@239824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ryanhaddad pushed a commit to WebKit/WebKit that referenced this issue Dec 22, 2020
…ands as failure

Tests don't expect user prompts to be handled in take screenshot commands, but that's going to change in the
spec soon, see w3c/webdriver#1359.

* TestExpectations.json:

Canonical link: https://commits.webkit.org/207810@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant