Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few commands are missing check for open browse context #879

Closed
vkatsikaros opened this issue Apr 3, 2017 · 3 comments
Closed

A few commands are missing check for open browse context #879

vkatsikaros opened this issue Apr 3, 2017 · 3 comments

Comments

@vkatsikaros
Copy link
Contributor

After #865 I noticed that a few other commands miss a check for open browse context:

I'll provide a patch for this in the next days.

@andreastt
Copy link
Member

These intentionally don’t have checks for an open top-level browsing context because they are meant to function without one.

@vkatsikaros
Copy link
Contributor Author

@andreastt ah ok, sorry for the false alarm then. So the 6.3 Processing Model will catch if there is a missing session id.

@andreastt
Copy link
Member

For example, we explicitly don’t check if there is an open top-level browsing context when calling Switch To Window because the old browsing context may have disappeared intentionally. It should then still be possible to switch to one of the other windows/tabs you have open. The same argument applies to Get Window Handles.

Similarly for Get Timeouts/Set Timeouts, the idea is that these should be unrelated to any state because they are simple getters and setters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants