Add warnings to indicate which sections have not been redefined #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreastt
changed the title
andreastt
changed the title
|
Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
|
Please can you rebase this? |
|
@AutomatedTester You appear to have closed this without merging the changes. I've just rebased it. |
|
woops, wrong-button-itis... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps readers from knowing which chapters they can (somewhat) rely on and which they should avoid if they dare to attempt an implementation.
For us as authors it also helps highlighting all the work that remains.