Revised draft of interactions section #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| The Actions API gives you a mechanism to do atomic interactions by sending over | ||
| a JSON object that can then be used to <a>dispatch commands</a>. | ||
| The commands are then <a data-lt=command-processed>processed</a> by the user agent, | ||
| allowing complex interactions to be created. |
There was a problem hiding this comment.
This feels a little unspecific. I think a nicer phrasing would be that it allows you to pipeline interaction actions to be performed atomically on the remote end, or something along those lines.
|
I should point out that I haven’t compared this to existing implementations like Marionette yet. I also haven’t finished reading it, but it’s overall a massive improvement to the status quo. |
|
Landed in cd0fb1b I have addressed all of Andreas' comments and since there are no other comments from other people I have felt it was better to land and then get people implementing it to report errors. It also creates the ability for others to submit PRs based on issues they are seeing when implementing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are issues in the prose for bits that are not complete but those can be completed as follow ups. The main feedback required is missing sections that have not been covered at all.
You can visit a rendered version of the section on my gh-pages