Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting of some 'element' occurences #549

Closed
wants to merge 4 commits into from
Closed

Formatting of some 'element' occurences #549

wants to merge 4 commits into from

Conversation

vkatsikaros
Copy link
Contributor

@vkatsikaros vkatsikaros commented Jan 18, 2017 •
edited by AutomatedTester

This change is Reviewable

@vkatsikaros vkatsikaros force-pushed the element_format branch 2 times, most recently from 73846d6 to dcae88b Compare January 18, 2017 09:24
@shs96c shs96c modified the milestone: Level 1 Jan 18, 2017
shs96c
shs96c requested changes Jan 18, 2017
View reviewed changes
Copy link
Contributor

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the Travis build is failing. Please run "validate"

webdriver-spec.html
@@ -3802,7 +3802,7 @@
<ol>
<li><p>Let <var>rectangle</var> be
the first element of the <a><code>DOMRect</code></a> sequence
returned by calling <a>getClientRects</a> on <var><a>element</a></var>.
returned by calling <a>getClientRects</a> on the <a>element</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/the element/element/

We need to mark the element in the text just above this as a variable too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I resolved this properly, let me know and sorry for the back and forth.

webdriver-spec.html
@@ -5048,7 +5048,7 @@
<a><code>type</code> attribute</a> is <a>File</a>:
<ol>
<li><p>Let <var>text</var> be the result of
joining together each element in <var>character array</var> to a string.
joining together each character in <var>character array</var> to a string.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may not have a normal character: it might be a grapheme cluster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

webdriver-spec.html
@@ -8060,7 +8060,7 @@
from the <var>parameters</var> argument.

<li><p>Let <var>text</var> be the result of
joining together each element in <var>character array</var> to a string.
joining together each character in <var>character array</var> to a string.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

@shs96c shs96c self-assigned this Jan 18, 2017
andreastt
andreastt previously requested changes Jan 19, 2017
View reviewed changes
webdriver-spec.html
<li><p>If <var>screenshot result</var> is a
<a><code>canvas</code> element</a>, let <var>encoding result</var>
be the result of <a>encoding as Base64</a> the
<var>screenshot result</var>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result is either success with some data or an error. Think of it as the Result enum in Rust.

Consequently, saying “if screenshot result is a <cavnas> element” doesn’t make sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I completely ignored this. Thanks.

shs96c
shs96c requested changes Jan 19, 2017
View reviewed changes
webdriver-spec.html
the first element of the <a><code>DOMRect</code></a> sequence
returned by calling <a>getClientRects</a> on <var><a>element</a></var>.
the first <a>element</a> of the <a><code>DOMRect</code></a> sequence
returned by calling <a>getClientRects</a> on <a>element</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<var>element<var> at the end of this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

andreastt
andreastt approved these changes Jan 20, 2017
View reviewed changes
Copy link
Member

@andreastt andreastt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@shs96c
Copy link
Contributor

shs96c commented Jan 20, 2017

Rebased, squashed, and pushed.

@shs96c shs96c closed this Jan 20, 2017
@vkatsikaros vkatsikaros deleted the element_format branch January 20, 2017 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c requested changes

@andreastt andreastt andreastt approved these changes

Assignees

@shs96c shs96c

Labels
None yet
Projects
None yet
Milestone
Level 1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vkatsikaros @shs96c @andreastt