New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow window position to be set with negative integers #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes.
shs96c
reviewed
Feb 23, 2017
webdriver-spec.html
Outdated
<li><p>Let <var>y</var> be the result of <a>getting a property</a> | ||
named <code>x</code> from the <var>parameters</var> argument, else let it be <a><code>null</code></a>. | ||
<li><p>Let <var>y</var> be the result of <a>getting a property</a> | ||
named <code>x</code> from the <var>parameters</var> argument, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<code>y</code>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
It should be allowed to set a window's position to negative x/y coordinates. Fixes: #804
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 15, 2017
…; r=maja_zf It should be possible to set a window's position to a pair of negative coordinates, since the user may move the window off-screen. The window may also be situated off-screen by default: for example a maximised window on Windows will report window.screenX to be -8px. Relevant change to the specification: w3c/webdriver#805 MozReview-Commit-ID: FdReDi8pLL0 --HG-- extra : rebase_source : 08bb52e10ffec16a1414d336653990c8d9d7e1a8
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 15, 2017
…. r=maja_zf, a=test-only It should be possible to set a window's position to a pair of negative coordinates, since the user may move the window off-screen. The window may also be situated off-screen by default: for example a maximised window on Windows will report window.screenX to be -8px. Relevant change to the specification: w3c/webdriver#805 MozReview-Commit-ID: FdReDi8pLL0 --HG-- extra : source : 78b008fb7d12ac75b2ad06d06ab65e6bc4ae8bb5
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 15, 2017
…. r=maja_zf, a=test-only It should be possible to set a window's position to a pair of negative coordinates, since the user may move the window off-screen. The window may also be situated off-screen by default: for example a maximised window on Windows will report window.screenX to be -8px. Relevant change to the specification: w3c/webdriver#805 MozReview-Commit-ID: FdReDi8pLL0 --HG-- extra : source : 78b008fb7d12ac75b2ad06d06ab65e6bc4ae8bb5 extra : intermediate-source : e0563eeab4043e203614bd505773b2396e4a2e30
Manishearth
pushed a commit
to Manishearth/gecko-dev
that referenced
this pull request
Mar 15, 2017
…; r=maja_zf It should be possible to set a window's position to a pair of negative coordinates, since the user may move the window off-screen. The window may also be situated off-screen by default: for example a maximised window on Windows will report window.screenX to be -8px. Relevant change to the specification: w3c/webdriver#805 MozReview-Commit-ID: FdReDi8pLL0
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Mar 16, 2017
…; r=maja_zf It should be possible to set a window's position to a pair of negative coordinates, since the user may move the window off-screen. The window may also be situated off-screen by default: for example a maximised window on Windows will report window.screenX to be -8px. Relevant change to the specification: w3c/webdriver#805 MozReview-Commit-ID: FdReDi8pLL0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…; r=maja_zf It should be possible to set a window's position to a pair of negative coordinates, since the user may move the window off-screen. The window may also be situated off-screen by default: for example a maximised window on Windows will report window.screenX to be -8px. Relevant change to the specification: w3c/webdriver#805 MozReview-Commit-ID: FdReDi8pLL0 UltraBlame original commit: 78b008fb7d12ac75b2ad06d06ab65e6bc4ae8bb5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…; r=maja_zf It should be possible to set a window's position to a pair of negative coordinates, since the user may move the window off-screen. The window may also be situated off-screen by default: for example a maximised window on Windows will report window.screenX to be -8px. Relevant change to the specification: w3c/webdriver#805 MozReview-Commit-ID: FdReDi8pLL0 UltraBlame original commit: 78b008fb7d12ac75b2ad06d06ab65e6bc4ae8bb5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…; r=maja_zf It should be possible to set a window's position to a pair of negative coordinates, since the user may move the window off-screen. The window may also be situated off-screen by default: for example a maximised window on Windows will report window.screenX to be -8px. Relevant change to the specification: w3c/webdriver#805 MozReview-Commit-ID: FdReDi8pLL0 UltraBlame original commit: 78b008fb7d12ac75b2ad06d06ab65e6bc4ae8bb5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is