Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish minutes of 2022-04-14 meeting #202

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Publish minutes of 2022-04-14 meeting #202

merged 1 commit into from
Apr 23, 2022

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Apr 14, 2022

Generated from https://docs.google.com/document/d/1QkwhEMtMS67JBUkl_WVPZ4lRSKoWcQNlLJSf_GwSXg8/edit using the tool and process from #105.

During this meeting we discussed or mentioned #195, #8, #191, #196, #197, #198, #199, #119 and #97. #170 was also part of the agenda, but we ran out of time before we got to discussing it.

* [timothy] That's the only thing we allow in Safari.
* [rob] In the issue you mentioned “Safari 14+ allows navigations” - does that mean same-origin navigation only and not remote URLs?
* [timothy] Yes.
* [simeon] Already covered what Chrome does here, but
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotproto Did you have more thoughts that you said for this line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tagging this, I'm updating this comment as part of my review.

_minutes/2022-04-14-wecg.md Show resolved Hide resolved
Copy link
Member

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few polish suggestions, but two are substantive (thus flagging as "requested changes")

  • Added a comment from Dave on which properties are exposed on which events.
  • Fleshed out my comment on background page navigation.

_minutes/2022-04-14-wecg.md Outdated Show resolved Hide resolved
_minutes/2022-04-14-wecg.md Show resolved Hide resolved
_minutes/2022-04-14-wecg.md Outdated Show resolved Hide resolved
_minutes/2022-04-14-wecg.md Outdated Show resolved Hide resolved
_minutes/2022-04-14-wecg.md Show resolved Hide resolved
_minutes/2022-04-14-wecg.md Outdated Show resolved Hide resolved
@Rob--W
Copy link
Member Author

Rob--W commented Apr 19, 2022

I have updated the PR to include the requested changes (and synced that with the Google doc), and pushed an update (along with some minor other fixes): https://github.com/w3c/webextensions/compare/3eff6a2a618c48cef033b94f42b145ed933baef3..f1d792c8a8a6251c6e35eabec2b7f5c4532f510a

I've also included a link to #200 in the meeting notes, since that was one of the requested changes.

Copy link
Member

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Rob--W!

@Rob--W Rob--W merged commit f777ee4 into main Apr 23, 2022
@Rob--W Rob--W deleted the meeting-2022-04-14 branch April 23, 2022 00:31
github-actions bot added a commit that referenced this pull request Apr 23, 2022
SHA: f777ee4
Reason: push, by @Rob--W

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants