Add support for [MapClass(type, type)]. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`argument_list` now return undefined when no arguments are found (rather than an empty array). `argument_list` also backtracks its changes when it cannot find any arguments.
This was referenced May 8, 2014
| } else if (pair = type_pair()) { | ||
| // [MapClass(DOMString, DOMString)] | ||
| ret.typePair = pair; | ||
| } else { |
There was a problem hiding this comment.
Can you please put both the elses above on their own lines?
There was a problem hiding this comment.
And move the comment describing what they do right before them.
// does foo
else {
}
|
All good except the small stylistic issue. |
darobin
added a commit
that referenced
this pull request
May 13, 2014
Add support for [MapClass(type, type)].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argument_listnow return undefined when no arguments are found (rather than an empty array).argument_listalso backtracks its changes when it cannot find any arguments.