Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop Node 6 support #102

Merged
merged 1 commit into from
Nov 2, 2017
Merged

chore: drop Node 6 support #102

merged 1 commit into from
Nov 2, 2017

Conversation

marcoscaceres
Copy link
Member

Follow latest stable and LTS going forward.

Follow latest stable and LTS going forward.
@marcoscaceres marcoscaceres merged commit 4f1aab4 into develop Nov 2, 2017
@marcoscaceres marcoscaceres deleted the node_lts branch November 2, 2017 03:11
@TimothyGu
Copy link
Member

@marcoscaceres Would you please reconsider this decision? According to the release schedule of Node.js, v6.x will remain in LTS through April of 2018. Since v6.x already has full support for ES2015, I don't expect too much (if any) additional work to come out of maintaining compatibility with v6.x.

I am a de-facto maintainer for webidl2js, which follows jsdom's pace on Node.js version support -- which is currently all active LTS branches + Current branch. Considering webidl2js composes 40% of the usage of webidl2.js by monthly downloads, it would be nice for this to be reverted.

@marcoscaceres
Copy link
Member Author

I'm ok with that. We don't use any async/await and only a few limited fancy things, so it should be fine. However, can you check and let us know if we need to revert any recent code changes (will make you in charge of keeping Node6 compat :)).

Also, @TimothyGu, I'll make you an official maintainer. Your participation has been invaluable thus far. I'll send you an invite.

@marcoscaceres
Copy link
Member Author

Actually, it seems you already part of the team 👍 Please add your details to the package.json file.

@TimothyGu
Copy link
Member

@marcoscaceres

However, can you check and let us know if we need to revert any recent code changes (will make you in charge of keeping Node6 compat :)).

Please add your details to the package.json file.

I'd be happy to do both of those :)

TimothyGu added a commit to TimothyGu/webidl2.js that referenced this pull request Nov 13, 2017
marcoscaceres pushed a commit that referenced this pull request Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants