Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always add rhs property #110

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Always add rhs property #110

merged 1 commit into from
Nov 3, 2017

Conversation

saschanaz
Copy link
Member

Fixes #96.

marcoscaceres
marcoscaceres reviewed Nov 3, 2017
View reviewed changes
lib/webidl2.js
@@ -343,32 +343,28 @@
name: name.value,
"arguments": null,
type: "extended-attribute",
rhs: null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now wondering if we should just make it an empty list?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, ignore this.

marcoscaceres
marcoscaceres approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, we should fix up the type switching throughout the parser... Generally speaking, and from a functional perspective, it's quite frustrating to deal with when you sometimes get nothing, sometimes an object, other times an array :(

@marcoscaceres marcoscaceres merged commit f26e320 into develop Nov 3, 2017
@marcoscaceres
Copy link
Member

Shipped at 8.1.0 :)

@saschanaz
Copy link
Member Author

Generally speaking, and from a functional perspective, it's quite frustrating to deal with when you sometimes get nothing, sometimes an object, other times an array :(

I agree, could you file an issue for that?

@marcoscaceres
Copy link
Member

filed:
#113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschanaz @marcoscaceres