Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent array type for iterable.idlType #117

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Consistent array type for iterable.idlType #117

merged 1 commit into from
Nov 30, 2017

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Nov 30, 2017 •
edited
Loading

This removes pain when processing iterable and its friends with different member counts. See #113

marcoscaceres
marcoscaceres approved these changes Nov 30, 2017
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot Woot!

@saschanaz saschanaz merged commit 24669ed into develop Nov 30, 2017
@saschanaz saschanaz deleted the iterable-array branch November 30, 2017 04:11
@marcoscaceres
Copy link
Member

This would classify as a "BREAKING CHANGE", yeah?

@saschanaz
Copy link
Member Author

Yes, so I added it on the commit message!

@marcoscaceres
Copy link
Member

Ah, excellent! thanks!

@marcoscaceres
Copy link
Member

  • webidl2@9.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschanaz @marcoscaceres