Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add const-type for idlTypes #132

Merged
merged 1 commit into from
Jan 30, 2018
Merged

feat: add const-type for idlTypes #132

merged 1 commit into from
Jan 30, 2018

Conversation

saschanaz
Copy link
Member

Now for const-type.

I'm not very happy with a field idlType again have its own idlType, can we rename it so that we can reduce same names?

@marcoscaceres
Copy link
Member

I'm not very happy with a field idlType again have its own idlType, can we rename it so that we can reduce same names?

I'm happy to go with whatever you think is best.

@saschanaz
Copy link
Member Author

Hmm. I have no good idea yet, I'll keep thinking about it.

@saschanaz saschanaz merged commit bde0553 into develop Jan 30, 2018
@saschanaz saschanaz deleted the const-type branch January 30, 2018 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschanaz @marcoscaceres