Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add argument/return type #134

Merged
merged 2 commits into from
Jan 30, 2018
Merged

feat: add argument/return type #134

merged 2 commits into from
Jan 30, 2018

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Jan 29, 2018 •
edited
Loading

Doing return-type will probably be enough rather than doing operation-type/callback-type, what do you think?

@marcoscaceres
Copy link
Member

Doing return-type will probably be enough rather than doing operation-type/callback-type, what do you think?

I like return-type 👍 Good idea.

@saschanaz saschanaz merged commit 6eb1e7f into develop Jan 30, 2018
@saschanaz saschanaz deleted the argument-type branch January 30, 2018 02:57
csnardi added a commit to csnardi/web-platform-tests that referenced this pull request Apr 26, 2018
@csnardi
Update expected text for test of IDL harness
ba7825d 
w3c/webidl2.js#133 and w3c/webidl2.js#134 changed the expected output by adding an attribute type.
csnardi added a commit to csnardi/web-platform-tests that referenced this pull request Apr 26, 2018
@csnardi
Update expected text for test of IDL harness
16a660c 
w3c/webidl2.js#133 and w3c/webidl2.js#134 changed the expected output by adding an attribute type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschanaz @marcoscaceres