Type on union idlType #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this can work, worst case, when I hit a null, I just walk up one level to figure out what it is. |
marcoscaceres
approved these changes
Jan 30, 2018
|
Do you have a use case for detecting types of each child idlType in a union type? |
|
Probably not, as they are styled and linked to definitions either in the spec, or to another spec (and I know that the context is "this is an IDL Type of some sort, not a concept"). However, I'll have a play with what we have thus far and can let you know soon. |
|
Thanks! We'll see what happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will better fit for #93, as otherwise we have to go one level deeper to get the type of a union type. What do you think?