Remove support for MapClass (no longer valid in WebIDL) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
requested changes
Apr 4, 2017
| // [Constructor()] | ||
| else { | ||
| ret["arguments"] = []; | ||
| } | ||
| all_ws(); | ||
| consume(OTHER, ")") || error("Unexpected token in extended attribute argument list or type pair"); | ||
| consume(OTHER, ")") || error("Unexpected token in extended attribute argument list"); |
There was a problem hiding this comment.
Can you include the erroneous token in the error? ": " + token). Makes it easier when reporting issues.
There was a problem hiding this comment.
WebIDLParseError already gives the context, à la:
Unexpected token in extended attribute argument list, line 1 (tokens: 'DOMString, DOMString)')
so I'm not sure this would add anything to that
marcoscaceres
approved these changes
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.