Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitespace error on parsing extended attributes #68

Merged
merged 1 commit into from
May 18, 2017
Merged

Fix whitespace error on parsing extended attributes #68

merged 1 commit into from
May 18, 2017

Conversation

saschanaz
Copy link
Member 

[
  Constructor,
  Constructor(double radius)
] // Currently errors here because the parser does not consume whitespaces before consuming bracket
interface Circle {
  attribute double r;
  attribute double cx;
  attribute double cy;
  readonly attribute double circumference;
};

marcoscaceres
marcoscaceres approved these changes May 18, 2017
View reviewed changes
test/syntax/idl/extended-attributes.widl
@@ -9,3 +9,15 @@ interface ServiceWorkerGlobalScope : WorkerGlobalScope {
// Section 3.11
[IntAttr=0, FloatAttr=3.14, StringAttr="abc"]
interface IdInterface {};

// Extracted from http://www.w3.org/TR/2016/REC-WebIDL-1-20161215/#Constructor on 2017-5-18 with whitespace differences
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: never take anything from the W3C WebIDL fork. It's obsolete. Please alway use https://heycam.github.io/webidl/

@marcoscaceres marcoscaceres merged commit f5d777c into w3c:develop May 18, 2017
@marcoscaceres
Copy link
Member

Published as webidl2@3.0.1 - thanks again for your help @saschanaz. You are a hero!

@saschanaz saschanaz deleted the fix-error branch May 18, 2017 07:35
@saschanaz saschanaz mentioned this pull request May 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschanaz @marcoscaceres