Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check duplicated names #80

Merged
merged 2 commits into from
Oct 16, 2017
Merged

Check duplicated names #80

merged 2 commits into from
Oct 16, 2017

Conversation

saschanaz
Copy link
Member

Fixes #77.

@saschanaz
Copy link
Member Author

I have a question, do we have to keep ES5 compatibility or can we use ES2015 now?

@marcoscaceres
Copy link
Member

It’s 2107, I say we embrace the future... and traspile our selves out of trouble if need be.

marcoscaceres
marcoscaceres approved these changes Sep 21, 2017
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe giving more context in the error message would be nice... like saying stating that a ${name} of ${type} was already seen.

@saschanaz
Copy link
Member Author

That will be good, I'll try it.

marcoscaceres
marcoscaceres approved these changes Sep 21, 2017
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@marcoscaceres marcoscaceres merged commit 174e47e into w3c:develop Oct 16, 2017
@marcoscaceres
Copy link
Member

@saschanaz, can you please add yourself to the contributors at https://github.com/w3c/webidl2.js/blob/develop/package.json

@saschanaz saschanaz deleted the checkDuplicates branch October 16, 2017 03:55
@saschanaz saschanaz mentioned this pull request May 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschanaz @marcoscaceres