Use ES2015 syntax for tests #88
Conversation
|
|
||
| describe("Parses all of the invalid IDLs to check that they blow up correctly", () => { | ||
| const dir = pth.join(__dirname, "invalid/idl"); | ||
| const skip = {}; |
There was a problem hiding this comment.
the skip should probably be a new Set(). I'm not sure skip very useful tho, as all the names are going to be unique, right?
There was a problem hiding this comment.
Probably an array will be sufficient enough as new Set() will eventually be written as new Set(["testname1", "testname2"]).
I'm not sure skip very useful tho, as all the names are going to be unique, right?
I'm sorry but not sure why the uniqueness makes skip not useful, can you clarify more?
There was a problem hiding this comment.
I guess the question is, under what circumstances will there be duplicate file names? (Or have I misunderstood what skip doing?) If the answer is "never", then the uniqueness check is not needed.
There was a problem hiding this comment.
Well, I think skip is for temporarily disabling a test which cannot be fixed in the short term, or just a test-to-do-later.
There was a problem hiding this comment.
I'm ok to keep it as is. If you are happy with it, I'm happy with it :)
There was a problem hiding this comment.
I think the uniqueness is even an assumption for skip as it would accidentally skip multiple tests if names are not unique.
| var idl = idls[i], json = jsons[i]; | ||
| describe("Parses all of the IDLs to produce the correct ASTs", () => { | ||
| const dir = pth.join(__dirname, "syntax/idl"); | ||
| const skip = {}; // use if we have a broken test |
| expect(error.message).toEqual(err.message); | ||
| expect(error.line).toEqual(err.line); | ||
| } | ||
| for (let i = 0, n = idls.length; i < n; i++) { |
There was a problem hiding this comment.
Nit:
for(const idl of idls) {
}There was a problem hiding this comment.
Couldn't do it because of errors[i].
|
published as webidl2@6.0.1 |
Looking at the tests I thought they should be rewritten in ES2015 before any possible fix here.
Additionally this removes lib-cov references that don't exist.