Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpt-sync] race condition between merging PR and creating a new one #46

Closed
foolip opened this issue Apr 8, 2020 · 0 comments · Fixed by #180
Closed

[wpt-sync] race condition between merging PR and creating a new one #46

foolip opened this issue Apr 8, 2020 · 0 comments · Fixed by #180

Comments

@foolip
Copy link
Member

foolip commented Apr 8, 2020

web-platform-tests/wpt#22785 (comment) describes the sequence of events that caused web-platform-tests/wpt#22774 to first be created, and then right as it was merged web-platform-tests/wpt#22785 was created and later closed again due to there being no changes.

The failure mode is fairly harmless since no changes are lost, but confusing.

We can detect this situation (existing branch but no PR) and add something to the PR description when it happens, similar to what we do when the .idl file in WPT has recently been modified by someone other than @autofoolip.

@stephenmcgruer do you have other ideas on what would have helped?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[wpt-sync] Remove the per-file syncing mechanism entirely w3c/webref
1 participant
@foolip